Opened 10 years ago

Closed 9 years ago

#8476 closed Patches (fixed)

Make Boost.regex compatible with Clang's -Wimplicit-fallthrough diagnostic.

Reported by: Alexander Kornienko <alexfh@…> Owned by: John Maddock
Milestone: To Be Determined Component: regex
Version: Boost Development Trunk Severity: Problem
Keywords: Cc: John Maddock

Description

Patch that inserts BOOST_FALLTHROUGH to annotate fallthrough between switch cases. Ticket with discussion of BOOST_FALLTHROUGH: #8408

Attachments (2)

regex.patch​ (5.1 KB ) - added by Alexander Kornienko <alexfh@…> 10 years ago.
boost-regex-fallthrough.patch​ (4.7 KB ) - added by Alexander Kornienko <alexfh@…> 9 years ago.

Download all attachments as: .zip

Change History (6)

by Alexander Kornienko <alexfh@…>, 10 years ago

Attachment: regex.patch​ added

comment:1 by John Maddock, 10 years ago

Resolution: → fixed
Status: new → closed

(In [84015]) Apply patch from #8476. Fixes #8476.

by Alexander Kornienko <alexfh@…>, 9 years ago

Attachment: boost-regex-fallthrough.patch​ added

comment:2 by Alexander Kornienko <alexfh@…>, 9 years ago

Thanks for applying the patch. Two things though:

  1. You've missed two times "break;" and one time "BOOST_FALLTHROUGH;". I've attached a diff from current HEAD to the version with the first patch.
  1. I've also noticed, that you've left "fall through/fallthrough/..." comments, which are redundant now. You definitely know better what's more readable to you, but after the change these comments really don't add any value.

comment:3 by Alexander Kornienko <alexfh@…>, 9 years ago

Resolution: fixed
Status: closed → reopened

comment:4 by John Maddock, 9 years ago

Resolution: → fixed
Status: reopened → closed

(In [84052]) Apply updated patches from #8476. Fixes #8476.

Note: See TracTickets for help on using tickets.