Opened 9 years ago

Closed 9 years ago

#9029 closed Bugs (fixed)

Misprint in documentation

Reported by: ruslan_baratov@… Owned by: viboes
Milestone: Boost 1.55.0 Component: thread
Version: Boost 1.54.0 Severity: Problem
Keywords: thread doc Cc:

Description

This page http://www.boost.org/doc/libs/1_54_0/doc/html/thread/build.html has misprint 'boost::thread::oprator=='. I guess it's 'boost::thread::operator=='

Change History (15)

comment:1 by viboes, 9 years ago

Owner: changed from Anthony Williams to viboes
Status: new → assigned

comment:2 by viboes, 9 years ago

Milestone: To Be Determined → Boost 1.55.0

Committed revision 85432.

comment:3 by ruslan_baratov@…, 9 years ago

Thanks. Do you accept github pull requests?

comment:4 by viboes, 9 years ago

Why not. The pb is to which github repository. Could you point me to which one?

comment:5 by ruslan_baratov@…, 9 years ago

No, I'm just asking for future. Quote from ​here: 

   Development should continue in Subversion only.

comment:6 by anonymous, 9 years ago

I've send 'Fix documentation misprints' to github.

in reply to:  6 ; comment:7 by viboes, 9 years ago

Replying to anonymous:

I've send 'Fix documentation misprints' to github.

Where can I see them?

in reply to:  7 comment:8 by ruslan_baratov@…, 9 years ago

Replying to viboes:

Replying to anonymous:

I've send 'Fix documentation misprints' to github.

Where can I see them?

github.com/boostorg/thread/pull/1

comment:9 by viboes, 9 years ago

Got it.

Committed revision [85485].

comment:10 by ruslan_baratov@…, 9 years ago

I've send one more:

Fix with_lock_guard documentation

github.com/boostorg/thread/pull/3

BTW, can't find this function declaration, where is it?

comment:11 by viboes, 9 years ago

Committed revision [85492].

The function is not provided. It is just an example.

in reply to:  11 ; comment:12 by ruslan_baratov@…, 9 years ago

Replying to viboes:

Committed revision [85492].

Thank you.

The function is not provided. It is just an example.

Why not? Looks nice: 

template <class Lockable, class Function, class... Args>
auto with_lock_guard(
    Lockable& m,
    BOOST_FWD_REF(Function) f,
    BOOST_FWD_REF(Args)... args
) -> decltype(f(args...)) {
  boost::lock_guard<Lockable> lock(m);
  return f(args...);
}

in reply to:  12 ; comment:13 by viboes, 9 years ago

Replying to ruslan_baratov@…:

Replying to viboes:

Committed revision [85492].

Thank you.

The function is not provided. It is just an example.

Why not? Looks nice: 

template <class Lockable, class Function, class... Args>
auto with_lock_guard(
    Lockable& m,
    BOOST_FWD_REF(Function) f,
    BOOST_FWD_REF(Args)... args
) -> decltype(f(args...)) {
  boost::lock_guard<Lockable> lock(m);
  return f(args...);
}

Well. All new function needs documentation, tests, fix bugs :( Please, create a new feature request (patches are as always welcome ;-)

in reply to:  13 comment:14 by ruslan_baratov@…, 9 years ago

Replying to viboes:

Well. All new function needs documentation, tests, fix bugs :( Please, create a new feature request (patches are as always welcome ;-)

​https://svn.boost.org/trac/boost/ticket/9058

comment:15 by viboes, 9 years ago

Resolution: → fixed
Status: assigned → closed

Committed revision [85603] on release branch.

Note: See TracTickets for help on using tickets.