Fix compilation using Sun CC standard library

[vz-boost@…]

I am not sure if this patch is going to be accepted, as it makes the code slightly longer and less clear, but it is needed to make the library build with Sun CC using its standard library (that we're unfortunately stuck with due to binary compatibility concerns). As std::vector simply doesn't provide a template ctor from 2 iterators, this is the best that can be done, AFAICS.

Here is the same patch as in the attachment, for convenience:

boost/test/impl/unit_test_main.ipp

@@ -110 +110 @@
         string_token_iterator tit( tc_to_run, (dropped_delimeters = "/", kept_delimeters = dt_none) );
 
         while( tit != string_token_iterator() ) {
-            m_filters.push_back(
-                std::vector<single_filter>( string_token_iterator( *tit, (dropped_delimeters = ",", kept_delimeters = dt_none)  ),
-                                            string_token_iterator() ) );
+            std::vector<single_filter> f;
+            for( string_token_iterator titf( *tit, (dropped_delimeters = ",", kept_delimeters = dt_none) ); titf != string_token_iterator(); ++titf )
+                f.push_back( *titf );
+
+            m_filters.push_back( f );
 
             ++tit;
         }

[vz-boost@…]

Proposed patch to fix the build with Sun CC

[Raffi Enficiaud]

We have now a builder for SunCC, and I believe the compilation should work now. Would you please test the boost master branch for us? We do not have access to this compiler.

[vz-boost@…]

Sorry, but I wasn't able to find this SunCC builder, could you please point me to it? I'd like to see how is it configured, but I suspect that it uses the newer (everything is relative...) STLPort-based standard library instead of the ancient RogueWave-based default standard library (see ​http://docs.oracle.com/cd/E19205-01/819-5267/bkakb/index.html for more information) that we are unfortunately forced to use.

[Raffi Enficiaud]

It is under SunOS there http://www.boost.org/development/tests/develop/developer/test.html

apparently using oracle compiler. This is the closest we have to your setup. Since I do not know anything about that platform and the toolchain, please report us in what extent the configuration is different to yours (it is using sun-stlport4).

[vz-boost@…]

stlport4 does confirm that it uses STLPort (or has a very misleading name), which explains why it passes. I haven't retried building the latest sources yet, but if they haven't changed and still use the same ctor, it still won't build with the default RogueWave STL as it doesn't have a template vector ctor.

[Raffi Enficiaud]

We will be needing your support for addressing this issue then. Would it be possible for you to test the current master or develop branch and report us any compilation issue? You can just run bjam from libs/test/test. We will then be able to know more about the effort needed by this issue.

[VZ]

It's probably useless to keep this open, I tried building Boost 1.60 with this compiler and it's just hopeless, there are too many errors due to missing std::iterator_traits and I'm not sure I can (or even want...) to correct them.

[Raffi Enficiaud]

There are several builds on the boost regression dashboard showing the result for the sun platform. I am sorry I cannot help more with this, at least the ppl making the compiler for this architecture are aware of the problems.