public method start_thread in boost::thread class

[dinazil@…]

There's a public method start_thread in the thread class. I couldn't find in the documentation what this method does.

In my code I accidentally called this method and it resulted in my callback being started twice.

Since calling the constructor implicitly starts the thread, I don't understand why such method should exist. I think that in one of the earlier versions of boost this was a private method. Is it possible that this method became public by mistake?

[viboes]

Yes this is an error, it must be private. I will fix it.

[viboes]

This patch should solve the issue.

git diff ../include/boost/thread/detail/thread.hpp
diff --git a/include/boost/thread/detail/thread.hpp b/include/boost/thread/detail/thread.hpp
index 2434723..5053b8d 100644
--- a/include/boost/thread/detail/thread.hpp
+++ b/include/boost/thread/detail/thread.hpp
@@ -172,7 +172,7 @@ namespace boost
     private:
         bool start_thread_noexcept();
         bool start_thread_noexcept(const attributes& attr);
-    public:
+    //public:
         void start_thread()
         {
           if (!start_thread_noexcept())

Please, could you confirm if you don't find any regression with it?

[viboes]

Committed in develop

​https://github.com/boostorg/thread/commit/4a54ac033132791ee488b9ca1a323fee205a0026

[dinazil@…]

This works for me (if I change just the .hpp file), but I didn't try compiling all of boost with this change. thanks!

[viboes]

​https://github.com/boostorg/thread/commit/750c849b0f0dff79a289111955260a4147ac7f59