Opened 9 years ago
Closed 8 years ago
#9886 closed Patches (fixed)
patch to fix GCC -Wshadow warnings in multi_array
| Reported by: | Owned by: | Ronald Garcia | |
|---|---|---|---|
| Milestone: | To Be Determined | Component: | multi_array |
| Version: | Boost Development Trunk | Severity: | Problem |
| Keywords: | Cc: | caolanm@…, tml@… |
Description
upstreaming patch from LibreOffice project, to fix compiler warnings
Attachments (2)
Change History (7)
by , 9 years ago
| Attachment: | 0002-multi_array-fix-GCC-Wshadow-warnings.patch added |
|---|
comment:1 by , 8 years ago
comment:2 by , 8 years ago
we want to build LibreOffice itself with -Wshadow (since that has found a couple of real bugs in our ancient code-base), and since boost's libraries have all the implementation in the headers that creates some problems for us.
it would be perfectly fine for us if you suppress the warnings via "#pragma GCC diagnostic push" "#pragma GCC diagnostic ignored "-Wshadow"" in boost if you prefer that.
comment:3 by , 8 years ago
Sure. Could you propose a new patch against the current master repository?
by , 8 years ago
| Attachment: | 0001-multi_array-suppress-GCC-Wshadow-warnings-fixes-9886.patch added |
|---|
comment:5 by , 8 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
| Version: | Boost Release Branch → Boost Development Trunk |
Patch applied to develop branch. Thanks!
Note:
See TracTickets
for help on using tickets.
This is a big patch that renames a lot of variables and typedefs. Are particular instances of shadowing here problematic? Shadowing in general is useful for reusing sensible names, especially in a local context where there is no ambiguity.